Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add workflow to release github-action #1543

Merged

Conversation

akshatnema
Copy link
Member

Description
Added a workflow that will complete following tasks:

  • Release the latest version of github-action in Dockerhub
  • Update action.yml with latest version of docker image

Related issue(s)

@aeworxet
Copy link
Contributor

@asyncapi/bounty_team

@asyncapi-bot asyncapi-bot added the bounty AsyncAPI Bounty program related label label Oct 15, 2024
@aeworxet
Copy link
Contributor

Implementation of asyncapi/github-action-for-cli#396 (comment)

the versions automation task


- name: Update action.yml with version
run: |
VERSION=${{ steps.version.outputs.value }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update to this action.yml won't be a part of the release though if this is done like this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shurtu-gal Yeah, do you want to run this workflow as part of pre-release or this update should be done before we build docker image of github-action?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akshatnema pre-release

@akshatnema akshatnema marked this pull request as ready for review October 18, 2024 14:34
on:
release:
types:
- prereleased
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this only works when you do a manual pre-release.
image

Copy link
Member Author

@akshatnema akshatnema Oct 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, so you can then proceed with the release, once the workflow is successful, right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the release is no longer automated if it has to be done manually. Let me correct the misunderstanding pre-release event will only work when a pre-release is done, which is done nowhere as far as I know.

Copy link

sonarcloud bot commented Oct 26, 2024

@Shurtu-gal Shurtu-gal merged commit 8be9928 into asyncapi:master Oct 27, 2024
21 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty AsyncAPI Bounty program related label released
Projects
Status: Completed
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants