Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The object passed as the value prop to the Context provider changes every render. To fix this consider wrapping it in a useMemo hook. #1526

Closed
AceTheCreator opened this issue Sep 30, 2023 · 3 comments
Closed

The object passed as the value prop to the Context provider changes every render. To fix this consider wrapping it in a useMemo hook. #1526

AceTheCreator opened this issue Sep 30, 2023 · 3 comments
Labels
good first issue Good for newcomers Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com

Comments

@AceTheCreator
Copy link
Member

Why this issue?

https://sonarcloud.io/project/issues?resolved=false&types=CODE_SMELL&id=asyncapi_generator-model-sdk&open=AYbwH5-yxKyPQbw46W-V&tab=why

Where's the issue?

https://sonarcloud.io/project/issues?resolved=false&types=CODE_SMELL&id=asyncapi_generator-model-sdk&open=AYbwH5-yxKyPQbw46W-V&tab=code
@Samridhi-98 Samridhi-98 added Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com good first issue Good for newcomers labels Oct 2, 2023
@AnishKacham
Copy link
Contributor

Hi, I'd like to work on this.

@AnishKacham
Copy link
Contributor

Hey, I don't think we can use Hooks here as it is a React Class component. So useMemo is a no go

@jonaslagoni
Copy link
Member

Yea, too much of a haggle to change probably. Thanks @AnishKacham, closing 🙂

Feel free to grab one of the other open issues 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jonaslagoni @AceTheCreator @Samridhi-98 @AnishKacham