Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] export AbstractDependencyManager to allow overriding #2005

Closed
2 tasks done
kamaz opened this issue May 20, 2024 · 2 comments · Fixed by #2044
Closed
2 tasks done

[FEATURE] export AbstractDependencyManager to allow overriding #2005

kamaz opened this issue May 20, 2024 · 2 comments · Fixed by #2044
Labels
enhancement New feature or request

Comments

@kamaz
Copy link
Contributor

kamaz commented May 20, 2024

Why do we need this improvement?

Currently, while it is possible to configure a generator, there is no access to the AbstractDependencyManager types because they are not exported. This limits the ability to utilize existing abstract classes to create custom AbstractDependencyManager instances when developing generators. For reference, the AbstractDependencyManager types are not exported in the index file.

How will this change help?

By exporting AbstractDependencyManager, developers will be able to create custom DependencyManager instances, enhancing the flexibility and extensibility of the generators.

Screenshots

No response

How could it be implemented/designed?

Add an export statement for AbstractDependencyManager in the index.ts file.

🚧 Breaking changes

No

👀 Have you checked for similar open issues?

  • I checked and didn't find a similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue?

Yes I am willing to submit a PR!

@kamaz kamaz added the enhancement New feature or request label May 20, 2024
Copy link
Contributor

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@kamaz kamaz changed the title [FEATURE] export AbstractGenerator to allow overriding [FEATURE] export AbstractDependencyManager to allow overriding May 21, 2024
@jonaslagoni
Copy link
Member

Go for it @kamaz ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants