Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite MPN code #39

Open
atas76 opened this issue Mar 20, 2024 · 0 comments
Open

Rewrite MPN code #39

atas76 opened this issue Mar 20, 2024 · 0 comments
Assignees
Labels
code quality in progress Half-baked and essential feature

Comments

@atas76
Copy link
Owner

atas76 commented Mar 20, 2024

I am not happy with the MPN processing code as it is. It is already growing into a maintenance nightmare, where the logic is about reading my own mind and putting the right values in the "right" places, which seem arbitrary and unintuitive at first glance.

A first step towards its improvement is to do some housekeeping, like common best practices, but I think a more drastic approach is required in the less short term (something along the lines of a partial rewrite, while the codebase is still relatively small). One idea would be to separate the construction of the 'flow chain' of events from their actual processing, so that 'dynamic' interventions are integrated more naturally with the data, and the processing and presentation logic are not mixed with 'decision making' logic and (chance) outcome handling.

But still cutting my teeth at this point is welcome, in order to identify as many of the potential issues to be addressed as possible.

UPDATE

It very difficult to debug and reproduce bugs with enough confidence. I need to rewrite the code, without altering something in its logic conceptually, but do the implementation changes mentioned above.

@atas76 atas76 assigned atas76 and unassigned atas76 Mar 20, 2024
@atas76 atas76 changed the title Refactor MPN code Rewrite MPN code Mar 21, 2024
@atas76 atas76 self-assigned this Mar 21, 2024
@atas76 atas76 added the in progress Half-baked and essential feature label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality in progress Half-baked and essential feature
Projects
None yet
Development

No branches or pull requests

1 participant