Study changes to t/op/*.t (2 of 12)

[jkeenan]

In this ticket we will study our progress in pursuit of Objective 2, "strict-by-default", for the following files in the Perl core distribution:

t/op/blocks.t
t/op/bop.t
t/op/caller.t
t/op/chdir.t
t/op/chop.t
t/op/chr.t
t/op/closure.t
t/op/cmpchain.t
t/op/concat2.t
t/op/cond.t

These files should be evaluated in light of the guidelines presented on this wiki page. Please post the summary of your findings in a single comment in this issue.

First-time contributors: (1) Please post a comment to this ticket indicating you are working on it. That will enable us to assign the ticket to you. (GitHub won't let us do that until it already thinks you're part of the project.) (2) You should subscribe to this repository so that you get email updates.

Thank you for helping to improve the Perl programming language.

[brainbuz]

I'll look at this.

[atoomic]

Thanks @brainbuz

[brainbuz]

There are two places where strictures can be deleted in these files. I'll send a PR proposing these.

file	pass	strictures not globally specified	reviewed diffs
t/op/blocks.t	x	x	x	failing todo for rt2917
t/op/bop.t	x	x	x
t/op/caller.t	x	---	x	2 todos failing, line 162 use strict can be removed.
t/op/chdir.t	x	x	x
t/op/chop.t	x	x	x
t/op/chr.t	x	x	x	lots of todos for objective 3.
t/op/closure.t	x	---	x	stricture at line 800
t/op/cmpchain.t	x	x	x	Line11 # no strict vars commented maybe delete?
t/op/concat2.t	x	x	x	Lin21 # commented no warnings
t/op/cond.t	x	x	x

[jkeenan]

Another good review. PR merged. Forge onward!