Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Study changes to t/op/*.t (11 of 12) #221

Closed
jkeenan opened this issue Aug 17, 2020 · 3 comments
Closed

Study changes to t/op/*.t (11 of 12) #221

jkeenan opened this issue Aug 17, 2020 · 3 comments
Assignees
Labels
study Study changes made by developers since 5.32.0

Comments

@jkeenan
Copy link
Collaborator

jkeenan commented Aug 17, 2020

In this ticket we will study our progress in pursuit of Objective 2, "strict-by-default", for the following files in the Perl core distribution:

t/op/threads.t
t/op/tiearray.t
t/op/tiehandle.t
t/op/time.t
t/op/time_loop.t
t/op/tr.t
t/op/universal.t
t/op/unshift.t
t/op/vec.t
t/op/ver.t
t/op/warn.t
t/op/while.t
t/op/write.t

These files should be evaluated in light of the guidelines presented on this wiki page. Please post the summary of your findings in a single comment in this issue.

First-time contributors: (1) Please post a comment to this ticket indicating you are working on it. That will enable us to assign the ticket to you. (GitHub won't let us do that until it already thinks you're part of the project.) (2) You should subscribe to this repository so that you get email updates.

Thank you for helping to improve the Perl programming language.

@jkeenan jkeenan added the study Study changes made by developers since 5.32.0 label Aug 17, 2020
@brainbuz
Copy link
Collaborator

brainbuz commented Oct 6, 2020

I can take a few more of these.

@brainbuz
Copy link
Collaborator

file pass strictures removed reviewed diffs notes
t/op/threads.t x --- x  
t/op/tiearray.t x x x  
t/op/tiehandle.t x --- x  
t/op/time.t x x x  
t/op/time_loop.t x x x  
t/op/tr.t x x x  
t/op/universal.t x x x  
t/op/unshift.t x x x  
t/op/vec.t x x x  
t/op/ver.t x x x  
t/op/warn.t x x x  
t/op/while.t x x x  
t/op/write.t x --- x Line 324 strict appears in a string passed to format.
        Removing at 1649
        Removing at 1662
        another format at 1920

write.t is testing write and format functions using blocks that look like perl code, my pull request will eliminate 2 of the stricts from these and leave the other 2.

@jkeenan
Copy link
Collaborator Author

jkeenan commented Oct 10, 2020

P.r. merged into alpha in commit c5c5fb4. Review looks complete. Closing ticket.

Thank you very much.
Jim Keenan

@jkeenan jkeenan closed this as completed Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
study Study changes made by developers since 5.32.0
Projects
None yet
Development

No branches or pull requests

2 participants