Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Study changes to t/re/*.t (1 of 3) #243

Closed
jkeenan opened this issue Aug 20, 2020 · 2 comments
Closed

Study changes to t/re/*.t (1 of 3) #243

jkeenan opened this issue Aug 20, 2020 · 2 comments
Labels
study Study changes made by developers since 5.32.0

Comments

@jkeenan
Copy link
Collaborator

jkeenan commented Aug 20, 2020

In this ticket we will study our progress in pursuit of Objective 2, "strict-by-default", for the following files in the Perl core distribution:

t/re/bigfuzzy_not_utf8.t
t/re/charset.t
t/re/fold_grind_8.t
t/re/fold_grind_T.t
t/re/fold_grind_a.t
t/re/fold_grind_aa.t
t/re/fold_grind_d.t
t/re/fold_grind_l.t
t/re/fold_grind_u.t
t/re/pat.t
t/re/pat_advanced.t

These files should be evaluated in light of the guidelines presented on this wiki page. Please post the summary of your findings in a single comment in this issue.

First-time contributors: (1) Please post a comment to this ticket indicating you are working on it. That will enable us to assign the ticket to you. (GitHub won't let us do that until it already thinks you're part of the project.) (2) You should subscribe to this repository so that you get email updates.

Thank you for helping to improve the Perl programming language.

@jkeenan jkeenan added the study Study changes made by developers since 5.32.0 label Aug 20, 2020
@khwilliamson
Copy link
Contributor

I looked at each of these tests on this ticket in blead and all have strict and warnings enabled. Some have a particular class of warning disabled, but for good reason.

@khwilliamson
Copy link
Contributor

so, to be clear I think this ticket can be closed, and you don't need to worry about the warnings objective either

@jkeenan jkeenan closed this as completed Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
study Study changes made by developers since 5.32.0
Projects
None yet
Development

No branches or pull requests

2 participants