Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup of code inconsistencies with guidelines/conventions #204

Open
averissimo opened this issue Dec 14, 2023 · 0 comments
Open

Cleanup of code inconsistencies with guidelines/conventions #204

averissimo opened this issue Dec 14, 2023 · 0 comments
Assignees
@EeethB
Labels
0.5.0 good first issue Good for newcomers

Comments

@averissimo
Copy link
Collaborator

averissimo commented Dec 14, 2023 •
edited
Loading

While looking at our current code base I noticed some small inconsistencies:

  • Use of double colon :: instead of importing (lifecycle, stringr, purrr, cli, rlang, etc..)
  • test files not following convention
    • test-<filename>.R
      • For example, in test-metadata.R there are a bunch of xportr_label tests
        • it should only test xportr_metadata
@averissimo averissimo added the good first issue Good for newcomers label Dec 14, 2023
@averissimo averissimo changed the title Cleanup of inconsistencies with guidelines/conventions Cleanup of conde inconsistencies with guidelines/conventions Dec 14, 2023
@averissimo averissimo changed the title Cleanup of conde inconsistencies with guidelines/conventions Cleanup of code inconsistencies with guidelines/conventions Dec 14, 2023
@EeethB EeethB self-assigned this Dec 14, 2023
@EeethB EeethB added the 0.5.0 label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EeethB EeethB

Labels
0.5.0 good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@averissimo @EeethB