Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purpose of Azure Vault? #11

Open
TuxCoder opened this issue Jun 23, 2020 · 0 comments
Open

Purpose of Azure Vault? #11

TuxCoder opened this issue Jun 23, 2020 · 0 comments

Comments

@TuxCoder
Copy link

When I read the code correctly the AzureSigner fetches the secret key from a website with some secret in the properties.

This has IMHO no security benefit to a secret key that is stored in the properties.
As an attacker can always fetch this secret when he has access to the web service.

For keeping stuff simpler and reduce dependencies I would recommend to remove this and replace it by a secret key as base64 decode in the properties.
Or generate it once the database get initialized and store it there, easier to handle for sysadmins.

Same security less code, full control, less failure points and easier testable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant