Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method Signatures are Inconsistent for Overridden Methods #76

Open
helegraf opened this issue Sep 27, 2023 · 0 comments
Open

Method Signatures are Inconsistent for Overridden Methods #76

helegraf opened this issue Sep 27, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@helegraf
Copy link
Contributor

Sometimes the typing of a method in a superclass (e.g. load_dependency_inputs in Plugin) allow different types for a parameter (in that case, None, List[AbstractRun]or AbstractRun for run) whereas in the subclasses a fixed type is assumed without checking (in that case, e.g. AbstractRunfor the Budget Correlation Plugin). This should be refactored to allow consistent types.

@helegraf helegraf added the enhancement New feature or request label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant