Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optimizer] Multi-fidelity algorithms should explicitly check for a fidelity parameter #120

Open
eddiebergman opened this issue Jul 31, 2024 · 0 comments
Labels
ux Something that would improve user experience

Comments

@eddiebergman
Copy link
Contributor

eddiebergman commented Jul 31, 2024

Right now if running SH with no fidelity parameter available, it will raise this error

        super().__init__(
            pipeline_space=pipeline_space,
            budget=budget,
            loss_value_on_error=loss_value_on_error,
            cost_value_on_error=cost_value_on_error,
            ignore_errors=ignore_errors,
            logger=logger,
        )
        if random_interleave_prob < 0 or random_interleave_prob > 1:
            raise ValueError("random_interleave_prob should be in [0.0, 1.0]")
        self.random_interleave_prob = random_interleave_prob
        self.sample_default_first = sample_default_first
        self.sample_default_at_target = sample_default_at_target
    
>       self.min_budget = self.pipeline_space.fidelity.lower
E       AttributeError: 'NoneType' object has no attribute 'lower'

This is not very descriptive on how to solve the problem. If implementing #119, we can simply check this and emit it in the BaseOptimizer.

Also seems to occur from hyperband_custom_default while not happening for hyperband. Priorband requires it too.

@eddiebergman eddiebergman added the ux Something that would improve user experience label Jul 31, 2024
@eddiebergman eddiebergman added this to the Optimizer Overhaul milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ux Something that would improve user experience
Projects
Status: No status
Development

No branches or pull requests

1 participant