Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable processing video capture while LEDs are off #490

Closed
lucasfeijo opened this issue Jan 18, 2023 · 1 comment · Fixed by #608
Closed

Disable processing video capture while LEDs are off #490

lucasfeijo opened this issue Jan 18, 2023 · 1 comment · Fixed by #608
Assignees
@awawa-dev
Labels
feature request

Comments

@lucasfeijo
Copy link

Feature request

Disable processing video capture while LEDs are off

What problem does this feature solve?

Unnecessary CPU and power usage while no LED is consuming the processed image.

What does the proposed API look like?

It wouldn't require API changes.

How should this be implemented in your opinion?

I'm not familiar with the hyperion codebase, but I think there would be modifications to the source selection logic to receive the on/off status of the LEDs and disable all sources if no LED controller reports being on.

Are you willing to work on this yourself?

Possibly if someone else gives me some information to get started.
@awawa-dev awawa-dev self-assigned this Apr 29, 2023
@awawa-dev awawa-dev mentioned this issue Jul 23, 2023
Merged
@awawa-dev
Copy link
Owner

Implemented in #608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@awawa-dev awawa-dev

Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New feature to pause the USB grabber when all LEDs are off awawa-dev/HyperHDR
2 participants
@lucasfeijo @awawa-dev