Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liveness VideoEndTimeStamp Used for Metrics is Incorrect #207

Open
2 tasks done
tylerjroach opened this issue Dec 27, 2024 · 1 comment
Open
2 tasks done

Liveness VideoEndTimeStamp Used for Metrics is Incorrect #207

tylerjroach opened this issue Dec 27, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@tylerjroach
Copy link
Member

Before creating a new issue, please confirm:

Which UI component?

Liveness

Gradle script dependencies

n/a

Environment information

n/a

Please include any relevant guides or documentation you're referencing

No response

Describe the bug

https://github.com/aws-amplify/amplify-android/blob/6bbb8c466e274caee8dca674d1acb6e8cbe5e372/aws-predictions/src/main/java/com/amplifyframework/predictions/aws/http/LivenessWebSocket.kt#L475

videoEndTimestamp ends up being the start time of the last video chunk containing data. This last video chunk could range from 0-1 seconds of content, resulting in the timestamp being off. This value is only used for metrics, and does not impact the challenge, as the actual end is determined by sending the empty video event.

For metric purposes, we should look to adjust this timestamp to be the proper end time.

Reproduction steps (if applicable)

No response

Code Snippet

// Put your code below this line.

Log output

// Put your logs below this line


amplifyconfiguration.json

No response

Additional information and screenshots

No response

Copy link
Contributor

This issue was opened by a maintainer of this repository; updates will be posted here. If you are also experiencing this issue, please comment here with any relevant information so that we're aware and can prioritize accordingly.

@github-actions github-actions bot added the pending-triage Issue is pending triage label Dec 27, 2024
@tylerjroach tylerjroach added the bug Something isn't working label Dec 27, 2024
@github-actions github-actions bot removed the pending-triage Issue is pending triage label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant