Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cfn validate doesn't validate missing properties #841

Open
richardhboyd opened this issue Oct 26, 2021 · 2 comments
Open

cfn validate doesn't validate missing properties #841

richardhboyd opened this issue Oct 26, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@richardhboyd
Copy link

If I have the following snippet in my schema

    "additionalProperties": false,
    "readOnlyProperties": [
        "/properties/TPSCode"
    ],
    "primaryIdentifier": [
        "/properties/TPSCode"
    ],

But I haven't actually defined a TPSCode in properties, I would expect cfn validate to fail.
@PatMyron
Copy link
Contributor

PatMyron commented Oct 28, 2021 •
edited
Loading

mentioned in aws-cloudformation/cloudformation-resource-schema#17 and #408 as well

@ammokhov ammokhov added the bug Something isn't working label Nov 9, 2021
@PatMyron PatMyron mentioned this issue Mar 17, 2022
Closed
mgentry612 pushed a commit to mgentry612/cloudformation-cli that referenced this issue Jul 9, 2022
@michaelgentrypgo
aws-cloudformation#841 add top level property definition validation
e1df982
@mgentry612 mgentry612 mentioned this issue Jul 9, 2022
Draft
@mgentry612
Copy link

@ammokhov , do you or anyone on the team have any time to review the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@PatMyron @mgentry612 @ammokhov @richardhboyd