Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for the transform processor #2300

Open
bmbferreira opened this issue Aug 28, 2023 · 18 comments
Open

Support for the transform processor #2300

bmbferreira opened this issue Aug 28, 2023 · 18 comments
Labels
ADOT collector ADOT Collector related issues feature-request Feature request processor processor related items

Comments

@bmbferreira
Copy link

bmbferreira commented Aug 28, 2023

Is your feature request related to a problem? Please describe.

I'm using fluentbit to forward the logs to the opentelemetry collector and I want to parse the json from the logs and then transform some of the fields to attributes using the transform procesor. However that processor doesn't seem to be supported by the AWS otel collector.

Describe the solution you'd like

I would like to have support for the transform processor to be able to do advanced transformations using the Opentelemetry Transformation Language.

Describe alternatives you've considered

Use the docker image from opentelemetry instead of using this one from AWS.

Additional context
N/A

@bmbferreira bmbferreira changed the title Support for transform processor Support for the transform processor Aug 28, 2023
@mhausenblas
Copy link
Member

Thanks for creating this feature request, certainly something we consider @bmbferreira. Please do note that at the moment we do not support logs GA in ADOT (see aws-observability/aws-otel-community#11 for details).

@mhausenblas mhausenblas added feature-request Feature request ADOT collector ADOT Collector related issues processor processor related items labels Aug 28, 2023
@jangaraj
Copy link

jangaraj commented Oct 3, 2023

I would like to have transform processor for my trace processing - I would like to rename service.name attribute if it is not in allowed set, e.g.:

transform:
  error_mode: ignore
  trace_statements:
    - context: resource
      statements:
        - set(attributes["service.name"], "not-whitelisted-service") where isMatch(["service-a","service-b"], attributes["service.name"])

@mhausenblas
Copy link
Member

Thank you, @jangaraj

@puckpuck
Copy link

+1 to getting this processor added to ADOT. We are working with a customer for whom the lack of this processor is causing heartburn.

@bpholt
Copy link

bpholt commented Nov 8, 2023

FWIW, I think this is a dupe of #1869. Very much hope it is picked up soon!

Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Jan 14, 2024
@MaGaudin
Copy link

is there any update on this? it will be very very useful to have it.

Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Mar 31, 2024
@hodgiwabi
Copy link

+1 for this processor, in the context of transforming histogram metrics for Dynatrace

@github-actions github-actions bot removed the stale label Apr 14, 2024
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@schmidt-galen-heb
Copy link

Bumping this issue again.

I'd like to use this processor to extract attributes from a log's Scope, which doesn't seem to be possible with the processors currently included in the ADOT collector, but seems like it would be trivial with this processor:

transform/datadog/logs:
  error_mode: ignore
  log_statements:
    - context: log
      statements:
        - set(attributes["logger.name"], instrumentation_scope.name)

@github-actions github-actions bot removed the stale label Jun 23, 2024
@will-sargent-eero
Copy link

bump, this matters because the opentelemetry-shim adds links to every span and Honeycomb treats a link as an extra span in searches.

@RafaelGBAccenture
Copy link

This feature is essential for efficiently processing message content towards CloudWatch. Having the transform processor would enable us to parse and filter logs effectively, allowing for better data management and more accurate insights. This capability is critical for creating efficient log filters and improving overall system observability. Thank you for considering this request.

@pankdhnd
Copy link

+1 for this. Transform processor is useful not only for logs but also for traces. It provides functionality for traces that no other processor provides. Kindly consider this request to have transform processor support as a part of ADOT.

@pcesara
Copy link

pcesara commented Aug 2, 2024

+100 This would be a very welcome feature.

Another use case is to manage attributes in metrics data points.
For example, taking Resource attributes and adding them as attributes in either Spans or Metrics data points.

Copy link
Contributor

github-actions bot commented Oct 6, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Oct 6, 2024
@mhausenblas mhausenblas removed the stale label Oct 7, 2024
@will-sargent-eero
Copy link

will-sargent-eero commented Oct 7, 2024 via email

@lasith-kg
Copy link

lasith-kg commented Oct 19, 2024

Transform Processor is an essential component of OTEL Collectors. Its applicability extends to Traces and Metrics. I believe its currently the only way to inject OTEL Resource Attributes into Prometheus Labels Reference. An essential piece of functionality if you want to run a central ADOT collector and then inject deployment labels to Prometheus metrics.

I would love to see the Transform Processor included within the ADOT Collector package ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADOT collector ADOT Collector related issues feature-request Feature request processor processor related items
Development

No branches or pull requests