Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECS FireLens compatibiltiy: Make it a drop in replacement for aws for fluent bit #2462

Open
project0 opened this issue Nov 3, 2023 · 14 comments
Assignees
Labels
logs Logs related issue

Comments

@project0
Copy link

project0 commented Nov 3, 2023

Is your feature request related to a problem? Please describe.

Most applications still send (structured/plain) logs to stdout and then depends on external scraping. Some opentelemetry sdk also do not support full OTLP log forward so there is no real alternative as of today.

Someone already using the opentelemetry collector for traces and metrics may also want to have a better integrated way with logs in ECS (Fargate). As of today there is no official documentation how to setup logging with the otel collector in AWS.
Afaik there are only two native ways: awslogs (cloudwatch) or firelens.

I did some research and experimented how to setup otel collector and i am actually surprised it works pretty well, so i wonder why i did not find any resource 😅
As Firelens is at the end just fluentd forwarding to a sidecar container, i do not see any reasons why we cannot just use the otel collector instead of a additional fluentd sidecar.

Describe the solution you'd like

  • Extend the components with the fluentforward receiver (native protocol support) and transform processor (required to parse json body logs)
  • Provide example configs in docs

Additional context

I put the relevant configs and a example task definition together, maybe someone else wants to use it today, but the ADOT is not supporting the relevant components yet:
https://github.com/project0/aws-ecs-firelens-opentelemetry

@mhausenblas mhausenblas self-assigned this Nov 6, 2023
@mhausenblas
Copy link
Member

@project0 thank you so much for this! Would you be willing to discuss this with me (ADOT PM) in some greater detail? I'm based out of Ireland, so shouldn't be too hard to find some time slot that works for both of us.

@luxaritas
Copy link

Also interested in this. @mhausenblas if you haven't already connected with @project0 and it would be helpful to provide any additional thoughts from my end, please let me know.

Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Feb 18, 2024
@luxaritas
Copy link

Keep open please!

@github-actions github-actions bot removed the stale label Feb 25, 2024
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Apr 28, 2024
@jameshulse
Copy link

Let's bump this one more time - hoping there has been some movement on it?

@mhausenblas mhausenblas added logs Logs related issue and removed stale labels Apr 29, 2024
@greaterthanmost
Copy link

Bumping this. This feature would be tremendously helpful!

Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Aug 18, 2024
@luxaritas
Copy link

Bump to keep open

@project0
Copy link
Author

Seems like @hyperdxio adopted this approach for ECS :-) : https://github.com/hyperdxio/aws-ecs-opentelemetry-sidecar/tree/main/examples

@github-actions github-actions bot removed the stale label Aug 25, 2024
@ksandrmatveyev
Copy link

Hello,
@mhausenblas any updates or plans for this?

@elixxx
Copy link

elixxx commented Sep 5, 2024

Any Progress here?

@mhausenblas
Copy link
Member

At this point we do not plan to add the fluentforward receiver to the ADOT collector. I will update this issue if and when this changes.

@ksandrmatveyev
Copy link

@mhausenblas, thank you for the response. Should we consider it as "may be", "yes" or "no"? As Opentelemetry becomes more and more like as a standard it will be great to have OTEL Collector to be supported by Firelens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logs Logs related issue
Projects
None yet
Development

No branches or pull requests

7 participants