Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected ReconnectionHealthPolicy behavior while using Content-share #2574

Open
yuchunli opened this issue Feb 2, 2023 · 0 comments
Open
Labels
feature-request New feature or request Triaged

Comments

@yuchunli
Copy link

yuchunli commented Feb 2, 2023

Community Note

  • Please vote for this issue by adding a 👍 reaction to the issue. This will help the community and maintainers from the Amazon Chime SDK team to prioritize this request.
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request.
  • Please go through the existing issues to see if your request has already been recommended.
  • Please do not use this template for bugs or support. Each individual repository has a PR template, documentation and resources for troubleshooting.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Tell us about your request

Hi team, our app currently has a custom health policy config as follows:

    healthPolicyConfiguration.missedPongsUpperThreshold = 1;
    healthPolicyConfiguration.connectionUnhealthyThreshold = 10;

Which will be set to ReconnectionHealthPolicy's static variables here.

However, DefaultContentShareController is created with createContentShareMeetingSessionConfigure, which doesn't copy the healthPolicyConfiguration over. As a result, when Content-share starts, another MonitorTask will be created, which eventually overrides those static variables of ReconnectionHealthPolicy with default healthPolicyConfiguration values, and thus caused the unexpected ReconnectionHealthPolicy behavior.

Recommended options:

  1. Copy the healthPolicyConfiguration over in createContentShareMeetingSessionConfigure
  2. Or convert static variables of ReconnectionHealthPolicy to be instance variables

What do you want us to build?

Which Amazon Chime SDK or feature area is this request for?
amazon-chime-sdk-js

Tell us about the problem you are trying to solve and why is it hard?

This issue cause inconsistent ReconnectionHealthPolicy behavior between Content-share ON and OFF.

How are you currently solving a problem?

We don't have a workaround for now.

Additional context

Anything else we should know?

@yuchunli yuchunli added the feature-request New feature or request label Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request Triaged
Projects
None yet
Development

No branches or pull requests

2 participants