Remove no-op segments from context when closed

[willarmiros]

Backgroumd

When a customer calls beginSegmentWithSampling and the decision is made to not sample, a NoOpSegment is inserted into the context:

aws-xray-sdk-java/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/AWSXRayRecorder.java

Line 431 in d9d17ec

return beginNoOpSegment();

However, when a customer calls close on that segment, it does not remove it from the context, leaving the stale no-op segment in context:

aws-xray-sdk-java/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/entities/NoOpSegment.java

Line 391 in 5bab3e5

public void close() {

This is distinct from SegmentImpl.close(), which does clear it from the context:

aws-xray-sdk-java/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/entities/SegmentImpl.java

Line 200 in 5bab3e5

public void close() {

Solution

We should consider removing the no-op segment from the context when closing it.