Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning for aws_stepfunctions.StateMachineProps #1231

Closed
kandakji opened this issue Nov 6, 2024 · 2 comments
Closed

Deprecation warning for aws_stepfunctions.StateMachineProps #1231

kandakji opened this issue Nov 6, 2024 · 2 comments
Labels
bug Something isn't working needs-triage The issue or PR still needs to be triaged

Comments

@kandakji
Copy link

kandakji commented Nov 6, 2024

When using S3ToStepfunctions construct, the following deprecation warning is thrown

[WARNING] aws-cdk-lib.aws_stepfunctions.StateMachineProps#definition is deprecated.
  use definitionBody: DefinitionBody.fromChainable()
  This API will be removed in the next major release.

Reproduction Steps

Error Log

Environment

  • CDK CLI Version : 2.165.0 (build 00f70f1)
  • CDK Framework Version:
  • AWS Solutions Constructs Version : 2.74.0
  • OS :
  • Language :

Other


This is 🐛 Bug Report

@kandakji kandakji added bug Something isn't working needs-triage The issue or PR still needs to be triaged labels Nov 6, 2024
@kandakji
Copy link
Author

kandakji commented Nov 6, 2024

Solved, just needed to use definition_body instead of definition

s3ToStepfunction = S3ToStepfunctions(
            self,
            "step-function",
            state_machine_props=sfn.StateMachineProps(
                definition_body=sfn.DefinitionBody.from_chainable(
                    
                ),
                tracing_enabled=True,
            ),
            existing_bucket_obj=input_bucket,
        )

@kandakji kandakji closed this as completed Nov 6, 2024
@biffgaut
Copy link
Contributor

biffgaut commented Nov 6, 2024

Glad to hear you've got a resolution. We're aware of the issue with our docs and some integration tests and are slowly addressing both across the whole library. For instance, the integration tests for that construct have already been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage The issue or PR still needs to be triaged
Projects
None yet
Development

No branches or pull requests

2 participants