ci: tweak the Python workflows #246
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthieu-d4r
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
matthieu-d4r
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
matthieu-d4r
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
matthieu-d4r
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
matthieu-d4r
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
matthieu-d4r
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
matthieu-d4r
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
matthieu-d4r
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
matthieu-d4r
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
matthieu-d4r
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
matthieu-d4r
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
matthieu-d4r
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
matthieu-d4r
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
matthieu-d4r
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
matthieu-d4r
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
matthieu-d4r
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
matthieu-d4r
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
matthieu-d4r
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
matthieu-d4r
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
matthieu-d4r
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
Remove manual installations of PyTorch everywhere, as the latter should be handled while installing the library through `pip`. Remove `-e` flag while installing our packages, and refer to them with `./`. Remove `s3torchbenchmarking` unit tests runs, unnecessary for now. Reformat some workflow files (cosmetic). Use `pip` instead of `python -m pip`. Drop support (in worfklows) for macOS x86_64 architecture, since PyTorch dropped support to since v2.3 (https://dev-discuss.pytorch.org/t/pytorch-macos-x86-builds-deprecation-starting-january-2024/1690), and future DCP implementations will require that version.
matthieu-d4r
force-pushed
the
ci/update-wkflw
branch
from
daa29f4
to
4d5b08b
Compare
matthieu-d4r
requested a deployment
to
integration-tests
GitHub Actions
Waiting
matthieu-d4r
requested a deployment
to
integration-tests
GitHub Actions
Waiting
matthieu-d4r
requested a deployment
to
integration-tests
GitHub Actions
Waiting
matthieu-d4r
requested a deployment
to
integration-tests
GitHub Actions
Waiting
matthieu-d4r
requested a deployment
to
integration-tests
GitHub Actions
Waiting
matthieu-d4r
requested a deployment
to
integration-tests
GitHub Actions
Waiting
matthieu-d4r
requested a deployment
to
integration-tests
GitHub Actions
Waiting
matthieu-d4r
requested a deployment
to
integration-tests
GitHub Actions
Waiting
matthieu-d4r
requested a deployment
to
integration-tests
GitHub Actions
Waiting
matthieu-d4r
requested a deployment
to
integration-tests
GitHub Actions
Waiting
matthieu-d4r
requested a deployment
to
integration-tests
GitHub Actions
Waiting
matthieu-d4r
requested a deployment
to
integration-tests
GitHub Actions
Waiting
matthieu-d4r
requested a deployment
to
integration-tests
GitHub Actions
Waiting
IsaevIlya
reviewed
Oct 24, 2024
| @@ -2,7 +2,7 @@ name: Integration tests (PR) | |||
|
|
|||
| on: | |||
| pull_request_target: | |||
| branches: [ "main", "feature/*" ] | |||
There was a problem hiding this comment.
Why we need ci prefix here?
IsaevIlya
reviewed
Oct 24, 2024
| @@ -32,7 +32,8 @@ test = [ | |||
| "flake8", | |||
| "black", | |||
| "mypy", | |||
| "Pillow" | |||
| "numpy", | |||
matthieu-d4r
requested a deployment
to
integration-tests
GitHub Actions
Waiting
matthieu-d4r
requested a deployment
to
integration-tests
GitHub Actions
Waiting
matthieu-d4r
requested a deployment
to
integration-tests
GitHub Actions
Waiting
matthieu-d4r
requested a deployment
to
integration-tests
GitHub Actions
Waiting
matthieu-d4r
requested a deployment
to
integration-tests
GitHub Actions
Waiting
matthieu-d4r
requested a deployment
to
integration-tests
GitHub Actions
Waiting
matthieu-d4r
requested a deployment
to
integration-tests
GitHub Actions
Waiting
matthieu-d4r
requested a deployment
to
integration-tests
GitHub Actions
Waiting
matthieu-d4r
requested a deployment
to
integration-tests
GitHub Actions
Waiting
matthieu-d4r
requested a deployment
to
integration-tests
GitHub Actions
Waiting
matthieu-d4r
requested a deployment
to
integration-tests
GitHub Actions
Waiting
matthieu-d4r
requested a deployment
to
integration-tests
GitHub Actions
Waiting
matthieu-d4r
requested a deployment
to
integration-tests
GitHub Actions
Waiting
matthieu-d4r
requested a deployment
to
integration-tests
GitHub Actions
Waiting
matthieu-d4r
requested a deployment
to
integration-tests
GitHub Actions
Waiting
matthieu-d4r
requested a deployment
to
integration-tests
GitHub Actions
Waiting
matthieu-d4r
requested a deployment
to
integration-tests
GitHub Actions
Waiting
matthieu-d4r
requested a deployment
to
integration-tests
GitHub Actions
Waiting
matthieu-d4r
requested a deployment
to
integration-tests
GitHub Actions
Waiting
matthieu-d4r
requested a deployment
to
integration-tests
GitHub Actions
Waiting
|
Cancelling with PR: will include changes within the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove manual installations of PyTorch everywhere, as the latter should
be handled while installing the library through
pip. Remove-eflagwhile installing our packages, and refer to them with
./. Removes3torchbenchmarkingunit tests runs, unnecessary for now. Reformatsome workflow files (cosmetic).
Drop support (in worfklows) for macOS x86_64 architecture, since PyTorch
dropped support to since v2.3
(https://dev-discuss.pytorch.org/t/pytorch-macos-x86-builds-deprecation-starting-january-2024/1690),
and future DCP implementations will require that version.
By submitting this pull request, I confirm that my contribution is made under the terms of BSD 3-Clause License and I agree to the terms of the LICENSE.