You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, we have two separate constructs in our config for providing registry specific configurations: ResolverConfig and Registry. The Registry config struct has been ported over from containerd/CRI. Containerd plans to move away from defining registry configurations directly in the config.toml and instead have users create host configuration files separately and provide the path to those configurations via the ConfigPath field. We should figure out a way to de-duplicate these constructs so that we have a centralized way of setting registry configurations.
Steps to reproduce the bug
No response
Describe the results you expected
(Preferred - Backwards Incompatible) Remove the CRI Registry struct and all other containerd specific fields from ResolverConfig and replace it with a ConfigPath field. Rename ResolverConfig to RegistryConfig.
Same as 1, but keep name as is ResolverConfig.
Remove our Registry config, import the Registry config type from containerd and merge it with ResolverConfig.
Host information
OS:
Snapshotter Version:
Containerd Version:
Any additional context or information about the bug
No response
The text was updated successfully, but these errors were encountered:
Description
Right now, we have two separate constructs in our config for providing registry specific configurations:
ResolverConfig
andRegistry
. TheRegistry
config struct has been ported over from containerd/CRI. Containerd plans to move away from defining registry configurations directly in theconfig.toml
and instead have users create host configuration files separately and provide the path to those configurations via theConfigPath
field. We should figure out a way to de-duplicate these constructs so that we have a centralized way of setting registry configurations.Steps to reproduce the bug
No response
Describe the results you expected
(Preferred - Backwards Incompatible) Remove the CRI
Registry
struct and all other containerd specific fields fromResolverConfig
and replace it with aConfigPath
field. RenameResolverConfig
toRegistryConfig
.Same as 1, but keep name as is
ResolverConfig
.Remove our
Registry
config, import theRegistry
config type from containerd and merge it withResolverConfig
.Host information
Any additional context or information about the bug
No response
The text was updated successfully, but these errors were encountered: