-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Throw warning upon importing rules with unsupported actions or events #159
Comments
Alternatively, we could create a parallel set of actions and events that use the D7 machine names but use the Backdrop callbacks, and add a deprecated watchdog message - kind of what core functions like I believe these are very few. |
That certainly sounds the most user-friendly for upgraders. |
A quick update on this.
So, validating those actions that use Vocabularies as parameters is something I still need to figure out. |
PR #181 is a "work in progress" - so far dealing with drupal_watchdog and drupal_message actions. |
New commit hides the actions from the select box in the Add new action page. Actions whose info contains a "hidden => TRUE" flag are hidden. |
I seem to have overlooked the PR for this issue up until now. @argiepiano, is this still WIP? |
@bugfolder, what's there works, but it doesn't completely address the issue. I haven't done any work on this lately. The idea here was to catch D7 imported rules that used actions that don't exist in Backdrop. It's probably a good idea to mark this as WIP |
Vocabularies were entities in D7. This means that imported D7 Rules that contain vocabulary entity actions or events will fail in Backdrop. We should figure out a way to catch those and throw a warning, or perhaps even correct/switch those to the newly created vocabulary actions and events.
This also applies programmatic imports, and rules stored in D7 db.
Not quite sure what the best approach is.
The text was updated successfully, but these errors were encountered: