Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent protobuf structure definition between rpcRequestMeta and brpc protobuf #92

Open
kevincai opened this issue Sep 9, 2023 · 0 comments

Comments

@kevincai
Copy link

kevincai commented Sep 9, 2023

https://github.com/baidu/Jprotobuf-rpc-socket/blob/master/jprotobuf-rpc-core/src/main/java/com/baidu/jprotobuf/pbrpc/data/RpcRequestMeta.java

    /** 分布式追踪 Parent Span ID. */
    @Protobuf(order = 6)
    private Long parentSpanId;

    /** 扩展字段. */
    @Protobuf(order = 7)
    private List<RpcRequestMetaExtField> extFields;

    /** 非PbRpc规范,用于传输额外的参数. */
    @Protobuf(fieldType = FieldType.BYTES, order = 110)
    private byte[] extraParam;

https://github.com/apache/brpc/blob/master/src/brpc/policy/baidu_rpc_meta.proto

message RpcRequestMeta {
    required string service_name = 1;
    required string method_name = 2;
    optional int64 log_id = 3;
    optional int64 trace_id = 4;
    optional int64 span_id = 5;
    optional int64 parent_span_id = 6;
    optional string request_id = 7; // correspond to x-request-id in http header
    optional int32 timeout_ms = 8;  // client's timeout setting for current call
}

when will jprotobuf rpc support set request id and timeout to rpc request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant