Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links in getting started guide should open in new tab #525

Closed
alisondavis17 opened this issue Jun 10, 2017 · 4 comments
Closed

Links in getting started guide should open in new tab #525

alisondavis17 opened this issue Jun 10, 2017 · 4 comments

Comments

@alisondavis17
Copy link
Contributor

Currently, links in the getting started guide open in the same tab, but links should open in new tabs so the user can keep the getting started guide open.

Examples of links that open in same tab but should open in a new tab:

screen shot 2017-06-09 at 10 15 56 pm

@zwalchuk
Copy link
Contributor

@craig-mulligan not sure where to fix this, I'm happy to fix if you show me where

@craigmulligan
Copy link
Contributor

@zwalchuk, so we can either add the links as html for example <a href="url" target="_blank">my link</a> or we could add some special markdown syntax for custom attributes.

I'd vote for the custom syntax as it'll keep things readable. To do that we need to expose the markdown renderer from the underlying doxx library, which should be possible right @emirotin?

@poshrolls
Copy link
Contributor

Topic for ProductOS / BalenaOS call - bigger issue for all docs.

@vipulgupta2048
Copy link
Member

Closing this in favor of #2621

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants