Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for additional arguments in the call function. #4

Open
Dirt-Nasty opened this issue Apr 18, 2021 · 2 comments · May be fixed by #98
Open

Add support for additional arguments in the call function. #4

Dirt-Nasty opened this issue Apr 18, 2021 · 2 comments · May be fixed by #98
Labels
enhancement New feature or request

Comments

@Dirt-Nasty
Copy link

Would it be possible to implement a way to pass additional field into the call function. Right now you are passing {to: address, data: data} into the call but there are some use cases for additional arguments. For example a few of the contracts I interact need a from argument as well.

Example:

self.w3.eth.call({'to': self.target, 'data': calldata, 'from': address})
@BobTheBuidler BobTheBuidler added the enhancement New feature or request label Jan 18, 2023
@BobTheBuidler
Copy link
Collaborator

we can probably catch **kwargs and update the params dict with them before contacting the node, wdyt?

@DefiDebauchery
Copy link
Contributor

DefiDebauchery commented Sep 17, 2024 •
edited
Loading

Are there any other worthwhile args to capture? If it's just from, perhaps it'd just be more straightforward to add it to the class members as tx_from= or origin=?

@DefiDebauchery DefiDebauchery linked a pull request Sep 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable setting an address origin for Call and Multicall operations DefiDebauchery/multicall.py
3 participants
@Dirt-Nasty @BobTheBuidler @DefiDebauchery