Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource updating is broken on latest master #84

Open
sagikazarmark opened this issue Sep 8, 2021 · 0 comments
Open

Resource updating is broken on latest master #84

sagikazarmark opened this issue Sep 8, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@sagikazarmark
Copy link
Member

sagikazarmark commented Sep 8, 2021

Describe the bug
Updating a resource always ends up in an error: Failed to unmarshal manifest: EOF

Steps to reproduce the issue:

  1. Create any k8s_manifest resource
  2. Try to change and update it

Expected behavior
Update should complete without errors

Additional context

I believe #79 introduced two serious breaking changes that led to this bug:

  • A new override_content argument was introduced to track the original content, but it's only set when ignore_fields is also provided
  • Similarly, new and original content values are not populated properly, unless ignore_fields is also provided

Looking at the PR override_content also seems to be redundant and unnecessary since ignored fields can be computed without storing it.

@sagikazarmark sagikazarmark added the bug Something isn't working label Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant