Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Potentially empty Makefile variable used without checks #32

Open
DavidMCerdeira opened this issue Dec 5, 2022 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@DavidMCerdeira
Copy link
Member

Describe the bug
ci.mk does not check if the CC variable has a value attributed to it. This may prevent the misra-check rule from executing correctly as it will not have a cc to invoke. In this case .cppcheck-types.cfg will not generate correctly.

To Reproduce
Steps to reproduce the behavior :

  1. clone the https://github.com/bao-project/bao-libvmm/ repository, and enter branch wip/base-infra
  2. run make -C ci/docker misra-check PLATFORM=qemu-aarch64-virt
  3. misra check will fail due to bad .cppcheck-types.cfg file

Expected behavior
Misra check ci rule should either terminate successfully or output

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Although this issue can be fixed by the projects that include bao-ci, bao-ci should perform sanity checks for uninitialized variables.

@DavidMCerdeira DavidMCerdeira added the bug Something isn't working label Dec 5, 2022
@josecm josecm self-assigned this Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants