Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incomplete type for BlockingConnection adapter __init__ parameters #5

Closed
baodrate opened this issue Jan 16, 2022 · 0 comments · Fixed by #8
Closed

Incomplete type for BlockingConnection adapter __init__ parameters #5

baodrate opened this issue Jan 16, 2022 · 0 comments · Fixed by #8

Comments

@baodrate
Copy link
Owner

The type of the BlockingConnection.__init__ parameters param is Optional[connection.Parameters]:

https://github.com/qubidt/pika-stubs/blob/a0e7b336e6b2f9a9bcde347725b9348871096080/pika-stubs/adapters/blocking_connection.pyi#L9-L15

But according to pika docs it should be "Connection parameters instance or non-empty sequence of them" i.e. Union[pika.connection.Parameters, Sequence[pika.connection.Parameters]]

Copied from hahow/pika-stubs/issues/7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Blocking Connection: allow sequence of parameters baodrate/types-pika
1 participant
@baodrate