From a1ff73f8d47b7630053a87a5fdc6f18cfe5f89cf Mon Sep 17 00:00:00 2001 From: thangnn Date: Fri, 11 Oct 2024 13:46:21 +0700 Subject: [PATCH 1/3] Add unitTest_InstallationsService_buildPermissions --- .../src/Service/InstallationsService.php | 1 + .../Service/InstallationsServiceTest.php | 17 +++++++++++++++++ 2 files changed, 18 insertions(+) diff --git a/plugins/bc-installer/src/Service/InstallationsService.php b/plugins/bc-installer/src/Service/InstallationsService.php index bc8adaadc8..95182ca777 100644 --- a/plugins/bc-installer/src/Service/InstallationsService.php +++ b/plugins/bc-installer/src/Service/InstallationsService.php @@ -593,6 +593,7 @@ public function sendCompleteMail(array $postData) * アクセスルールを構築する * @checked * @noTodo + * @unitTest */ public function buildPermissions() { diff --git a/plugins/bc-installer/tests/TestCase/Service/InstallationsServiceTest.php b/plugins/bc-installer/tests/TestCase/Service/InstallationsServiceTest.php index 433a853467..29c24bb3db 100644 --- a/plugins/bc-installer/tests/TestCase/Service/InstallationsServiceTest.php +++ b/plugins/bc-installer/tests/TestCase/Service/InstallationsServiceTest.php @@ -11,9 +11,11 @@ namespace BcInstaller\Test\TestCase\Service; +use BaserCore\Service\PermissionGroupsServiceInterface; use BaserCore\Test\Factory\ContentFactory; use BaserCore\Test\Factory\ContentFolderFactory; use BaserCore\Test\Factory\SiteFactory; +use BaserCore\Test\Scenario\InitAppScenario; use BaserCore\TestSuite\BcTestCase; use BaserCore\Utility\BcContainerTrait; use BaserCore\Utility\BcFile; @@ -22,6 +24,7 @@ use BcInstaller\Service\InstallationsServiceInterface; use Cake\Core\Configure; use Cake\ORM\Exception\PersistenceFailedException; +use CakephpFixtureFactories\Scenario\ScenarioAwareTrait; /** * InstallationsServiceTest @@ -34,6 +37,7 @@ class InstallationsServiceTest extends BcTestCase * Trait */ use BcContainerTrait; + use ScenarioAwareTrait; /** * setup @@ -397,4 +401,17 @@ public function testCreateDefaultFiles() } } + /** + * test buildPermissions + */ + public function test_buildPermissions() + { + $this->loadFixtureScenario(InitAppScenario::class); + $this->Installations->buildPermissions(); + + $permissionGroupsService = $this->getService(PermissionGroupsServiceInterface::class); + $permissionGroups = $permissionGroupsService->getlist(); + $this->assertCount(28, $permissionGroups); + } + } From 578521d017cd6c0353ad48b14b4b16b4076e7c45 Mon Sep 17 00:00:00 2001 From: thangnn Date: Thu, 17 Oct 2024 11:27:44 +0700 Subject: [PATCH 2/3] modified --- .../tests/TestCase/Service/InstallationsServiceTest.php | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/plugins/bc-installer/tests/TestCase/Service/InstallationsServiceTest.php b/plugins/bc-installer/tests/TestCase/Service/InstallationsServiceTest.php index e8d6cc85a7..54083ecfb5 100644 --- a/plugins/bc-installer/tests/TestCase/Service/InstallationsServiceTest.php +++ b/plugins/bc-installer/tests/TestCase/Service/InstallationsServiceTest.php @@ -465,8 +465,14 @@ public function testCreateDefaultFiles() public function test_buildPermissions() { $this->loadFixtureScenario(InitAppScenario::class); - $this->Installations->buildPermissions(); + //check before buildPermissions + $permissionGroupsService = $this->getService(PermissionGroupsServiceInterface::class); + $permissionGroups = $permissionGroupsService->getlist(); + $this->assertCount(0, $permissionGroups); + + //buildPermissions + $this->Installations->buildPermissions(); $permissionGroupsService = $this->getService(PermissionGroupsServiceInterface::class); $permissionGroups = $permissionGroupsService->getlist(); $this->assertCount(28, $permissionGroups); From bf371881c4fa1700f811cc3e7fe3d00aed366b73 Mon Sep 17 00:00:00 2001 From: thangnn Date: Fri, 18 Oct 2024 10:29:25 +0700 Subject: [PATCH 3/3] modified --- .../tests/TestCase/Service/InstallationsServiceTest.php | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/plugins/bc-installer/tests/TestCase/Service/InstallationsServiceTest.php b/plugins/bc-installer/tests/TestCase/Service/InstallationsServiceTest.php index 54083ecfb5..726e79d6d4 100644 --- a/plugins/bc-installer/tests/TestCase/Service/InstallationsServiceTest.php +++ b/plugins/bc-installer/tests/TestCase/Service/InstallationsServiceTest.php @@ -464,8 +464,6 @@ public function testCreateDefaultFiles() */ public function test_buildPermissions() { - $this->loadFixtureScenario(InitAppScenario::class); - //check before buildPermissions $permissionGroupsService = $this->getService(PermissionGroupsServiceInterface::class); $permissionGroups = $permissionGroupsService->getlist(); @@ -475,7 +473,7 @@ public function test_buildPermissions() $this->Installations->buildPermissions(); $permissionGroupsService = $this->getService(PermissionGroupsServiceInterface::class); $permissionGroups = $permissionGroupsService->getlist(); - $this->assertCount(28, $permissionGroups); + $this->assertCount(4, $permissionGroups); } }