Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use *_admin transactions for admin actions #109

Closed
3 tasks done
orthecreedence opened this issue Sep 1, 2020 · 1 comment
Closed
3 tasks done

Use *_admin transactions for admin actions #109

orthecreedence opened this issue Sep 1, 2020 · 1 comment
Labels
project:core status:wontfix type:discussion Discussion or ideas for future direction, input welcome (don't be shy)
Milestone

Comments

@orthecreedence
Copy link
Member

orthecreedence commented Sep 1, 2020

For instance in Company::delete we have an Option<Member> where we should just have Member (or Membership #108) but we have a weird placeholder for the Member in case it's an admin deleted. That should really be a different transaction, with the same base call.

Note to self: :vim /Permission.*Admin/gj **/*.rs:

  • transactions/user.rs - This was already the case. Good job.
  • transactions/company.rs - Removed admin management for companies. Smash hierarchies, comrade.
  • transactions/events/work.rs (I don't think this applies, although maybe it does...) Yeah, not going to bother with this one. Marking done.
@orthecreedence
Copy link
Member Author

Thinking now, this might make the already-obtuse API even more obstuse. Not sure if this is the right path.

@orthecreedence orthecreedence modified the milestones: v0.3 - Core, Roadmap Sep 4, 2020
@orthecreedence orthecreedence added type:discussion Discussion or ideas for future direction, input welcome (don't be shy) and removed type:bug labels Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project:core status:wontfix type:discussion Discussion or ideas for future direction, input welcome (don't be shy)
Projects
None yet
Development

No branches or pull requests

1 participant