Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope some types of warnings to main repo only #24751

Open
keith opened this issue Dec 18, 2024 · 2 comments
Open

Scope some types of warnings to main repo only #24751

keith opened this issue Dec 18, 2024 · 2 comments
Assignees
Labels
team-Local-Exec Issues and PRs for the Execution (Local) team type: feature request untriaged

Comments

@keith
Copy link
Member

keith commented Dec 18, 2024

Description of the feature request:

With bazel @ f4b071c there is a new deprecation warning about the use of config_setting:

WARNING: /.../BUILD.bazel:176:15: in config_setting rule //:linux_x86_64: select() on cpu is deprecated. Use platform constraints instead: https://bazel.build/docs/configurable-attributes#platforms.

This warning is fine on its own, but when building a non-trivial project, you will likely get dozens of this same warning from projects you don't control, such as these from grpc:

WARNING: /.../external/grpc+/BUILD:192:15: in config_setting rule @@grpc+//:mac_arm64: select() on cpu is deprecated. Use platform constraints instead: https://bazel.build/docs/configurable-attributes#platforms.

These external projects aren't very actionable, but are very noisy in build logs. I think we should consider scoping some types of warnings to only the main repo to avoid this noise.

This could cause some false-positives when you're creating the repos yourself, meaning using an internal foo.BUILD file that produces the warning.

Another option would be allow users to disable specific warnings like these instead of having to disable all warnings with --ui_event_filters=-WARNING

Which category does this issue belong to?

No response

What underlying problem are you trying to solve with this feature?

No response

Which operating system are you running Bazel on?

ubuntu 22.04 x86_64

What is the output of bazel info release?

f4b071c

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse HEAD ?

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@keith
Copy link
Member Author

keith commented Dec 18, 2024

@katre @gregestren

@keith
Copy link
Member Author

keith commented Dec 18, 2024

@gregestren it looks like there are some of these triggered by bazel itself too, regardless of this can you fix those?

WARNING: /github/home/.cache/bazel/_bazel_root/991c1318309cea4e3284840cbcc05428/external/bazel_tools/src/conditions/BUILD:145:27: in config_setting rule @@bazel_tools//src/conditions:host_windows_arm64_constraint: select() on host_cpu is deprecated. Use platform constraints instead: https://bazel.build/docs/configurable-attributes#platforms.
WARNING: /github/home/.cache/bazel/_bazel_root/991c1318309cea4e3284840cbcc05428/external/bazel_tools/src/conditions/BUILD:145:27: in config_setting rule @@bazel_tools//src/conditions:host_windows_x64_constraint: select() on host_cpu is deprecated. Use platform constraints instead: https://bazel.build/docs/configurable-attributes#platforms.

@sgowroji sgowroji added the team-Local-Exec Issues and PRs for the Execution (Local) team label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Local-Exec Issues and PRs for the Execution (Local) team type: feature request untriaged
Projects
None yet
Development

No branches or pull requests

5 participants