Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove allocation instrumenter jar and update version in docs #24783

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Remove allocation instrumenter jar and update version in docs #24783

wants to merge 4 commits into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Dec 20, 2024 •
edited
Loading

The jar can be supplied separately as it needs to be passed to the -javaagent JVM arg anyway.

Also update the recommended version for compatibility with Java 21.

Fixes #24782

@fmeum
Fix rule memory tracking and remove allocation instrumenter jar
65fcc9d 
The jar needs to supplied separately so that it can be passed to the `-javaagent` JVM arg and thus doesn't need to be part of the server jar.

Also update the recommended version for compatibility with Java 21.
@fmeum fmeum requested review from meisterT and removed request for gregestren and fweikert December 20, 2024 19:32
@github-actions github-actions bot added team-Performance Issues for Performance teams team-Documentation Documentation improvements that cannot be directly linked to other team labels awaiting-review PR is awaiting review from an assigned reviewer labels Dec 20, 2024
@fmeum fmeum mentioned this pull request Dec 20, 2024
Open
@fmeum fmeum marked this pull request as draft December 21, 2024 00:27
@fmeum fmeum changed the title Fix rule memory tracking and remove allocation instrumenter jar Remove allocation instrumenter jar and update version in docs Dec 21, 2024
@fmeum fmeum marked this pull request as ready for review December 21, 2024 17:10
@fmeum
Copy link
Collaborator Author

fmeum commented Dec 23, 2024

@bazel-io fork 7.5.0

@fmeum
Copy link
Collaborator Author

fmeum commented Dec 23, 2024

@bazel-io fork 8.0.1

This was referenced Dec 23, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meisterT meisterT Awaiting requested review from meisterT

Assignees
No one assigned
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-Documentation Documentation improvements that cannot be directly linked to other team labels team-Performance Issues for Performance teams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bazel Memory Tracker shows incorrect memory consumption
1 participant
@fmeum