From 8da83580de2fa019e87677caa89d26cc1e8ae2ce Mon Sep 17 00:00:00 2001 From: Kuzniar Date: Thu, 14 Sep 2023 13:47:27 -0700 Subject: [PATCH 1/2] Updated history table to show up after loading --- frontend/src/components/SubmissionHistory.vue | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/frontend/src/components/SubmissionHistory.vue b/frontend/src/components/SubmissionHistory.vue index 89c53299..e0d684af 100644 --- a/frontend/src/components/SubmissionHistory.vue +++ b/frontend/src/components/SubmissionHistory.vue @@ -25,6 +25,7 @@ disable-pagination hide-default-footer :sort-by="['priority', 'submissionDate']" :sort-desc="[true, true]" + v-if="!processing" > @@ -53,8 +54,7 @@ import alertMixin from '@/mixins/alertMixin'; import NavButton from './util/NavButton.vue'; import {ApiRoutes} from '@/utils/constants'; - - + export default { @@ -78,10 +78,7 @@ }; }, computed: { - ...mapState('app', ['programYearList']), - ...mapState('application', ['applicationStatus', 'formattedProgramYear', 'applicationId']), - ...mapState('reportChanges', ['changeRequestStore','userProfileChangeRequests']), - ...mapState('navBar', ['userProfileList']), + ...mapState('application', ['applicationId']), ...mapState('document',['pdfs']), isReadOnly() { return false; @@ -110,9 +107,7 @@ }, methods: { - ...mapActions('reportChanges', ['getChangeRequestList', 'createChangeRequest', 'cancelChangeRequest']), ...mapActions('document',['getPDFs']), - ...mapMutations('reportChanges', ['setChangeRequestId', 'setChangeActionId']), previous() { this.$router.push(PATHS.ROOT.HOME); }, From 7e86c0293a86d4ab269f53b8ed36aad032f0add9 Mon Sep 17 00:00:00 2001 From: Kuzniar Date: Thu, 14 Sep 2023 14:59:51 -0700 Subject: [PATCH 2/2] Removed code smells --- frontend/src/components/SubmissionHistory.vue | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frontend/src/components/SubmissionHistory.vue b/frontend/src/components/SubmissionHistory.vue index c967ffaf..70f88454 100644 --- a/frontend/src/components/SubmissionHistory.vue +++ b/frontend/src/components/SubmissionHistory.vue @@ -49,11 +49,11 @@