-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Node 12 with Node 18 #36
Comments
On CentOS v7.6.1810 (phage.bcgsc.ca), I checkout https://github.com/bcgsc/pori_graphkb_api/tree/feature/replace-node-12-with-node-18-36 from develop, rebuild the node_modules with node 18.3.0, uninstall commitizen and cz-conventional-changelog dependencies follow by an npm audit fix as we did with #40. All GH checks passed. @creisle, should I add node 18 here ?
|
Ok, I changed node 12 for 18 in the workflows, but both orientdb 3.0 and 3.1 were failing so I rolled back. |
The source code of orientjs package didn't had a commit since 2y on develop and 4y on master. Tests performed on npm include node v10 and v12 only. I wonder if moving to node 18 now is too soon. |
Are the errors you are seeing related to orientjs? can you copy/paste the relevant error messages to this ticket |
yes, and remove 12 |
Here is a branch with tests for Node v.18 : https://github.com/bcgsc/pori_graphkb_api/tree/feature/replace-node-12-with-node-18-36b. Here is the logs: https://github.com/bcgsc/pori_graphkb_api/runs/6888639803?check_suite_focus=true File here: 5_orientdb-3.0 node-18.txt |
When "npm start" the api with Node.js v18+, we inevitably encounter this error:
Here is what it's going on:
|
Tasks
Checks
The text was updated successfully, but these errors were encountered: