Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Node 12 with Node 18 #36

Open
3 tasks
creisle opened this issue May 13, 2022 · 7 comments
Open
3 tasks

Replace Node 12 with Node 18 #36

creisle opened this issue May 13, 2022 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@creisle
Copy link
Member

creisle commented May 13, 2022

Tasks

Checks

  • Test on centos07
  • Test on ubuntu (github build)
  • Test build with docker container
@creisle creisle added the enhancement New feature or request label May 13, 2022
@mathieulemieux
Copy link
Member

mathieulemieux commented Jun 10, 2022

On CentOS v7.6.1810 (phage.bcgsc.ca), I checkout https://github.com/bcgsc/pori_graphkb_api/tree/feature/replace-node-12-with-node-18-36 from develop, rebuild the node_modules with node 18.3.0, uninstall commitizen and cz-conventional-changelog dependencies follow by an npm audit fix as we did with #40. All GH checks passed.

@creisle, should I add node 18 here ?

@mathieulemieux
Copy link
Member

mathieulemieux commented Jun 10, 2022

Ok, I changed node 12 for 18 in the workflows, but both orientdb 3.0 and 3.1 were failing so I rolled back.
Put the changes in another branch to show errors in log : https://github.com/bcgsc/pori_graphkb_api/tree/feature/replace-node-12-with-node-18-36b

@mathieulemieux
Copy link
Member

The source code of orientjs package didn't had a commit since 2y on develop and 4y on master. Tests performed on npm include node v10 and v12 only. I wonder if moving to node 18 now is too soon.

@creisle
Copy link
Member Author

creisle commented Jun 20, 2022

Are the errors you are seeing related to orientjs? can you copy/paste the relevant error messages to this ticket

@creisle
Copy link
Member Author

creisle commented Jun 20, 2022

On CentOS v7.6.1810 (phage.bcgsc.ca), I checkout https://github.com/bcgsc/pori_graphkb_api/tree/feature/replace-node-12-with-node-18-36 from develop, rebuild the node_modules with node 18.3.0, uninstall commitizen and cz-conventional-changelog dependencies follow by an npm audit fix as we did with #40. All GH checks passed.

@creisle, should I add node 18 here ?

yes, and remove 12

@mathieulemieux
Copy link
Member

mathieulemieux commented Jun 20, 2022

@mathieulemieux
Copy link
Member

mathieulemieux commented Jun 21, 2022

When "npm start" the api with Node.js v18+, we inevitably encounter this error:

  • "TypeError: Cannot set property closed of # which has only a getter"

Here is what it's going on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants