Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No POST params logged #104

Open
kylecrum opened this issue Jun 13, 2014 · 3 comments
Open

No POST params logged #104

kylecrum opened this issue Jun 13, 2014 · 3 comments

Comments

@kylecrum
Copy link
Contributor

As far as I can tell, it appears that POST params don't end up in the logging.

@shaqq
Copy link
Contributor

shaqq commented Oct 29, 2014

POST params get kind of big, so that's most likely the biggest blocker.

Would we consider logging the keys of the params though? Or, if we'd like, we could do some smart truncation of the values.

@jdoconnor
Copy link
Contributor

would logging the params in DEBUG make sense vs INFO?

On Wed, Oct 29, 2014 at 11:31 AM, Shaker Islam [email protected]
wrote:

POST params get kind of big, so that's most likely the biggest blocker.

Would we consider logging the keys of the params though? Or, if we'd
like, we could do some smart truncation of the values.


Reply to this email directly or view it on GitHub
#104 (comment).

@kylecrum
Copy link
Contributor Author

kylecrum commented Nov 3, 2014

Well, how do you guys debug POST requests in prod? Since most of my log viewing comes at the service of a log aggregation service and searching via that, I personally don't see what's so bad about logging POST params.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants