Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Add compilationOption requirement of tsconfig to README.md #672

Open
jayjo34 opened this issue Nov 15, 2023 · 1 comment
Open

Enhancement: Add compilationOption requirement of tsconfig to README.md #672

jayjo34 opened this issue Nov 15, 2023 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@jayjo34
Copy link

jayjo34 commented Nov 15, 2023

After a long time of failures using <Table>.primaryKey (kept undefined) and almost getting crazy everything worked after changing compilerOptions to :
"compilerOptions": { "module": "commonjs", "target": "es2019", ...

Please add this to the README.
@benhutchins
Copy link
Owner

Can do. Dyngoose currently does not work using esm modules, it does need to be used within a commonjs. I do plan to change this to better support use with modern projects and those utilizing sst and similar systems.

I actually have a branch with this but I need to ensure reliable backwards compatibility with comnmonjs projects.

@benhutchins benhutchins added the documentation Improvements or additions to documentation label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benhutchins @jayjo34