Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Found problem in code #70

Open
ZhangWei88 opened this issue Jul 2, 2018 · 0 comments
Open

Found problem in code #70

ZhangWei88 opened this issue Jul 2, 2018 · 0 comments

Comments

@ZhangWei88
Copy link

ZhangWei88 commented Jul 2, 2018

Hi dear.

How are you?
I have found a problem in the source code so would like to notice to you.
I tried to use async data load function for multiselect but got javascript error whenever open dropdown.
So I checked the source code of multiselect and found there is a problem.
I think you should replace these lines :

$scope.toggleDropdown = function () {
      $scope.open = !$scope.open;
      $scope.resolvedOptions = $scope.options;
      updateSelectionLists();
};

by these lines :

$scope.toggleDropdown = function () {
      $scope.open = !$scope.open;
      if (typeof $scope.options !== 'function') {
            $scope.resolvedOptions = $scope.options;
      }
      updateSelectionLists();
};

I think this problem had been made when fix the issue #21 .
I hope this report would help you even a little.

Thanks,
Zhang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant