Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read and apply custom build option on flash page #4228

Open
mituritsyn opened this issue Oct 26, 2024 · 3 comments
Open

Read and apply custom build option on flash page #4228

mituritsyn opened this issue Oct 26, 2024 · 3 comments

Comments

@mituritsyn
Copy link
Contributor

Is your feature request related to a problem? Please describe

not related to problem

Describe the solution you'd like

At current BFC will read and apply build options used in the firmware but will ignore custom defines

Describe alternatives you've considered

parse and apply custom defines too
for example, having following config after reflash I'll lost custom define for POS_HOLD_OPTION

https://build.betaflight.com/api/builds/f47415a1ce059c7d9b65b7d620e02351/log

Other information

No response

@haslinghuis
Copy link
Member

haslinghuis commented Oct 26, 2024

Already planned to add altitude hold and position hold to firmware build options in betaflight/betaflight#13974 but position hold is still in progress. There are a lot of custom defines possible.

@mituritsyn
Copy link
Contributor Author

Already planned to add altitude hold and position hold to firmware build options in betaflight/betaflight#13974 but position hold is still in progress. There are a lot of custom defines possible.

poshold was just an example there always will be a bunch of other custom options

@nerdCopter
Copy link
Member

agree, would be nice if "auto-detect" populated the "custom defines".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants