Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Optional) Codebase Optimizations #58

Open
6 tasks
c6z3h opened this issue Feb 8, 2023 · 0 comments
Open
6 tasks

(Optional) Codebase Optimizations #58

c6z3h opened this issue Feb 8, 2023 · 0 comments

Comments

@c6z3h
Copy link
Collaborator

c6z3h commented Feb 8, 2023

  • package.json: consider placing some dependencies as dev dependencies, which basically won't be added to the final LIVE package. This will reduce app size (more useful for mobile apps actually). Example: @types / lint checkers -- you just need them to format on save, don't need to have it when building the LIVE app. The code will be bundled & minified anyway.
  • add eslintrc.{language} file to lint for errors or warnings. Can follow Airbnb standard (I think they have a package to npm install).
  • add .vscode/settings.json to automate agreed-upon code standards for all contributors in project (eg. tab-spaces 4 or 2)
  • components don't need so clean. That is JAVA style. Scripting language is more permissive. Dude with 5 year React experience also said 200-line file? No problem!
  • instead of setting height and width of components, consider using Flex component of chakra-ui!
  • consider adding husky pre-commit hooks to run lint before commit to ensure that code does not have funny breaking changes (?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant