Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: ask: --password should use read --silent with a confirm password prompt #227

Open
balupton opened this issue May 23, 2024 · 3 comments
Labels
enhancement Improvement or suggestion PR / Bounty only External demand, as such, external funding / effort is required to make this happen

Comments

@balupton
Copy link
Member

balupton commented May 23, 2024

Currently if one uses ask --password it just prevents it from being outputted after being entered, however read (at least on macos) supports --silent which obfuscates what is entered with dots.... If Dorothy were to change ask to use this mode, then ask will need to verify the characters were entered with an additional confirm prompt. This may be a few days of work, which currently has no requirement in Dorothy currently. If someone needs this, post below, and hopefully a bounty can be arranged.

@balupton balupton added the enhancement Improvement or suggestion label May 23, 2024
@balupton
Copy link
Member Author

balupton commented May 24, 2024

In addition, could do some hotkey combination such as a SIG* in which it cancels the silent read and uses a prefilled read with the entered characters now visible.

@balupton
Copy link
Member Author

balupton commented May 26, 2024

Perhaps a --conceal flag makes sense for this, in which a --secret flag enables both password and conceal.

Will also need a --confirm-repeat flag, as sometimes we don't care for the confirm, as an external program validates.

@balupton
Copy link
Member Author

balupton commented Aug 6, 2024

Full flow:

You have been prompted to enter a password for: secret vault encryption
- type a concealed password
- type a visible password
- use no password

If concealed:

Type the password for: secret vault encryption
> ******
Confirm the password:
> ******

If visible:

Type the password for: secret vault encryption
> pass123

If typing and press escape, go back to the select menu.

If confirm:

You have been prompted to enter a password for: secret vault encryption
- use the provided password
- type a concealed password
- type a visible password
- use no password

@balupton balupton added the PR / Bounty only External demand, as such, external funding / effort is required to make this happen label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement or suggestion PR / Bounty only External demand, as such, external funding / effort is required to make this happen
Development

No branches or pull requests

1 participant