Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"crop": false, "crop_aspect": "random" aspect ratio bucket should have sane ratio minima/maxima #1113

Open
AmericanPresidentJimmyCarter opened this issue Oct 30, 2024 · 2 comments
Open

"crop": false, "crop_aspect": "random" aspect ratio bucket should have sane ratio minima/maxima #1113

AmericanPresidentJimmyCarter opened this issue Oct 30, 2024 · 2 comments

Comments

@AmericanPresidentJimmyCarter
Copy link

Processing bucket 74.0: 0%| probably should not happen. I don't think such an image works with the positional embeddings of most models. Consider a ratio_min and ratio_max option in the dataset configurations.
@bghira
Copy link
Owner

bghira commented Oct 30, 2024

well, if crop is false then crop_aspect=random does not apply

@AmericanPresidentJimmyCarter
Copy link
Author

OK, edited title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bghira @AmericanPresidentJimmyCarter