Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flux AI Toolkit preset generate completly noisy image in Comfy UI. #1119

Open
axel578 opened this issue Nov 3, 2024 · 3 comments
Open

Flux AI Toolkit preset generate completly noisy image in Comfy UI. #1119

axel578 opened this issue Nov 3, 2024 · 3 comments

Comments

@axel578
Copy link

axel578 commented Nov 3, 2024

It might not necessarely be a Comfy UI issue since all flux lora training I did on kohya/onetrainer seems to work, and the issue seems to be pretty recent seens it was working with simpletuner before, I used two days old simpletuner version, yet the new version did'nt seem to fix it.

I used your default flux lora training especially with quanto (let me know if its the issue) and use flux target ai-toolkit
Just so you can test it a lora: https://drive.google.com/file/d/1mpFHMTOfbAXVLKKj8A5IfWLr0VIoT32K/view?usp=sharing

@bghira
Copy link
Owner

bghira commented Nov 3, 2024

ai-toolkit target is not really supported. it is probably safe to remove now, in fact. i would recommend just all or all+ffs for LoRA.

but really LoRA is kinda outdated tech by now. LyCORIS LoKr works much better.

@axel578
Copy link
Author

axel578 commented Nov 3, 2024

ai-toolkit target is not really supported. it is probably safe to remove now, in fact. i would recommend just all or all+ffs for LoRA.

but really LoRA is kinda outdated tech by now. LyCORIS LoKr works much better.

Yeah, I know the popularity of LyCORIS LoKr and why its know, its very good on paper, but there are many properties (especially on multi resolution) where it doesnt work that well, yet its still pretty good.

Don't remove ai-toolkit, really the more layers the lora is applied on, the easier it is to train a lora on very complex and far away from original learned distribution images, people are judging lora quality only on very easy image dataset (someone's face ...), but they really forget about the capacity of the lora for learning hard styles/image compositons, to be fair, I modified adapter.py to target near every layers of the model and its where I get the best result really.

@bghira
Copy link
Owner

bghira commented Nov 3, 2024

LoKr has nothing to do with multi-resolution, that's the underlying model at play. unless @KohakuBlueleaf can explain if I am overlooking something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants