Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #27 - Add S800 #547

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

napsternxg
Copy link

Please name your PR after the issue it closes. You can use the following line: "Closes #ISSUE-NUMBER" where you replace the ISSUE-NUMBER with the one corresponding to your dataset.

Fixes #27 - Add S800

If the following information is NOT present in the issue, please populate:

Checkbox

  • Confirm that this PR is linked to the dataset issue.
  • Create the dataloader script biodatasets/my_dataset/my_dataset.py (please use only lowercase and underscore for dataset naming).
  • Provide values for the _CITATION, _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _BIGBIO_VERSION variables.
  • Implement _info(), _split_generators() and _generate_examples() in dataloader script.
  • Make sure that the BUILDER_CONFIGS class attribute is a list with at least one BigBioConfig for the source schema and one for a bigbio schema.
  • Confirm dataloader script works with datasets.load_dataset function.
  • Confirm that your dataloader script passes the test suite run with python -m tests.test_bigbio biodatasets/my_dataset/my_dataset.py.
  • If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

@sg-wbi sg-wbi changed the title Fixes #27 - Add S800 Closes #27 - Add S800 May 9, 2022
@phlobo
Copy link
Collaborator

phlobo commented Jul 25, 2024

Hi @napsternxg! We are currently in the process of going through open issues and PRs and merging them whenever possible. Would it be doable for you to update your PR (and others you created) according to the latest contribution guide, i.e., making it compatible with the HF Hub?

If you don't have bandwidth for this, me and other maintainers would try to amend your PR by making the required changes ourselves, ideally still giving due credit to your contribution while doing that.

Please let me know what you think!

@phlobo phlobo self-assigned this Jul 25, 2024
@napsternxg
Copy link
Author

Thanks @phlobo for the tag.
Unfortunately, I don't have bandwidth at the moment to work on this as its been quite a while I worked with this code and it would require significant effort from my end. I would appreciate if your team can take care of this PR.

@phlobo phlobo removed their assignment Sep 6, 2024
@phlobo phlobo self-assigned this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create dataset loader for S800 Corpus
2 participants