Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some validations should be callbacks. #578

Open
tiegz opened this issue Dec 6, 2017 · 1 comment
Open

Some validations should be callbacks. #578

tiegz opened this issue Dec 6, 2017 · 1 comment
Milestone

Comments

@tiegz
Copy link
Contributor

tiegz commented Dec 6, 2017

Namely in the magic columns, there are some counter increments that are done as validations. It'd be nice to refactor these to be callbacks instead.

@jaredbeck jaredbeck added this to the 4.0.0 milestone Dec 6, 2017
@jaredbeck
Copy link
Collaborator

Good catch. There are at least two that I see:

  • increase_failed_login_count
  • reset_failed_login_count

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants