Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCUMENTATION: Insufficient alternative for ns.go.analysis.getValidMoves() #1576

Open
bupjae opened this issue Aug 13, 2024 · 3 comments
Open
Labels
documentation Improvements or additions to documentation

Comments

@bupjae
Copy link
Contributor

bupjae commented Aug 13, 2024

Currenr dev branch

RAM cost: 8 GB (This is intentionally expensive; you can derive this info from just getBoardState() )

We also have to determine getMoveHistory() to comply no-repeat rule.

// Detect if the move might be an immediate repeat (only one board of history is saved to check)
const possibleRepeat = boardState.previousBoards.find((board) => getColorOnBoardString(board, x, y) === player);

The comment says only one board of history is checked, but the code actually checks full history.

@d0sboots
Copy link
Collaborator

You might want to open this as either an issue or a PR, commenting on the repo will get lost.

@bupjae
Copy link
Contributor Author

bupjae commented Aug 13, 2024

I think I just created (= open?) the issue, including current repo as link.

I didn't know it is possible to comment on the repo directly.

@d0sboots
Copy link
Collaborator

Oh weird, this is an issue. I was just brain-farting when looking at it.

Yeah, it is possible to comment on the repo directly. I'm not sure how, but I've seen it done by someone in a different repo that I have notifications on. XD

@gmcew gmcew added the documentation Improvements or additions to documentation label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants