Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing commands #7

Open
8 of 12 tasks
danielabrozzoni opened this issue Feb 19, 2022 · 4 comments
Open
8 of 12 tasks

Add missing commands #7

danielabrozzoni opened this issue Feb 19, 2022 · 4 comments
Labels
good first issue Good for newcomers

Comments

@danielabrozzoni
Copy link
Member

danielabrozzoni commented Feb 19, 2022

At the moment, this crate only supports some HWI commands.
We are missing:
Optional arguments:

Commands:

This issue shouldn't be tackled in one giant PR. Instead, please, open one PR each new command/argument you add.

@danielabrozzoni danielabrozzoni added the good first issue Good for newcomers label Feb 19, 2022
@fireballpoint1
Copy link

Hi @danielabrozzoni, is there documentation I can refer to, for the expected functionality of wipe (or other commands too)?

@danielabrozzoni
Copy link
Member Author

Sure :) You should look at the HWI docs: https://hwi.readthedocs.io/en/latest/

I'd also suggest to install some hardware wallet simulator and try out the various commands yourself using the hwi cli, as described in my link above :)

@anishagg17
Copy link
Contributor

anishagg17 commented Jun 1, 2022

How should I tackle --interactive ? Also I think togglepassphrase is the easiest one to add currently

@danielabrozzoni
Copy link
Member Author

How should I tackle --interactive ?

Eh, I'm not really sure. I'd start with playing around with hwi to understand how it's used...

Also I think togglepassphrase is the easiest one to add currently

Cool! Leave a comment under this issue if you want to work on it :)

danielabrozzoni added a commit that referenced this issue Dec 19, 2022
e56ce96 Add backup_device (Yuki Kishimoto)

Pull request description:

  Refs #7

ACKs for top commit:
  danielabrozzoni:
    utACK e56ce96

Tree-SHA512: e82867d8ea323003d687709f9e9f3e81cd02b8c93a3b4b673577a6e796411e6a7e9552ff4e6790830767ee1435bddcfe145c21dc62d06086138489f94f64ae3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants