Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace reset estimator in non-swarm examples #323

Open
knmcguire opened this issue Mar 7, 2022 · 2 comments
Open

Replace reset estimator in non-swarm examples #323

knmcguire opened this issue Mar 7, 2022 · 2 comments

Comments

@knmcguire
Copy link
Member

The reset estimator has been converted for all swarm examples to a cflib function but not for the regular single drone examples...

It would improve the cleanliness of all the examples, but might compromise the backward compatiblity that #288 was experiencing.

@diegoch-it
Copy link

diegoch-it commented Jul 18, 2024

@knmcguire These are the examples to be modified (by folder):

In autonomy:
-autonomousSequence.py
-autonomous_sequence_high_level.py
-autonomous_sequence_high_level_compressed.py
-circling_square_demo.py
-full_state_setpoint_demo.py

In lighthouse
-lighthouse_openvr_grab.py
-lighthouse_openvr_grab_color.py
-lighthouse_openvr_multigrab.py

In mocap
-mocap_hl_commander.py
-qualisys_hl_commander.py

In positioning
-flowsequenceSync.py
-initial_position.py

The function to be created in SyncCrazyflie class and replaced in the examples are:
-reset_estimator()
-wait_for_position_estimator()

Should I create a pull request for each example?

@knmcguire
Copy link
Member Author

absolutely! Make sure to test it out though on at least one :) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants