Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please consider fixing tensorflow imports #1

Open
NeilGirdhar opened this issue Jul 28, 2020 · 2 comments
Open

Please consider fixing tensorflow imports #1

NeilGirdhar opened this issue Jul 28, 2020 · 2 comments

Comments

@NeilGirdhar
Copy link

Thank you very much for uploading this. Would it be possible to get it working? Currently, tensorflow does not have a tf.contrib. And most tensorflow imports should be replaced with tensorflow.compat.v1. I'm going to start porting the movies problem to JAX.

Thanks for any help!

@yixinwang
Copy link
Collaborator

Thanks for writing! I think the code should run out of the box if you use python 2, tensorflow 1.5.0, and edward 1.3.5. With these (old) versions of the packages, we will not need to change the imports to tensorflow.compat.v1 or tf.contrib.

@NeilGirdhar
Copy link
Author

NeilGirdhar commented Jul 28, 2020

Thank you for the fast reply!

I intend to compare your results with a custom implementation on the same data. That means I need to get it working in modern Python. (Python 2 is dead, and most importantly JAX doesn't support it.) I will let you know if I have any other problems porting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants