Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if endpoint URL resolves before adding the monitor #513

Open
gorkem-bwl opened this issue Jul 31, 2024 · 4 comments · May be fixed by #946
Open

Check if endpoint URL resolves before adding the monitor #513

gorkem-bwl opened this issue Jul 31, 2024 · 4 comments · May be fixed by #946
Labels
good first issue Good for newcomers

Comments

@gorkem-bwl
Copy link
Contributor

gorkem-bwl commented Jul 31, 2024

When adding a monitor, the endpoint must be checked to move forward with adding.

If the endpoint URL doesn't resolve, it should throw a notification saying that the endpoint doesn't resolve. During the endpoint checking process, the "Create new monitor" button should read "Checking the endpoint".

There are two options:

  1. If the endpoint doesn't resolve, it should throw a toast notification saying "The endpoint you entered doesn't resolve. Check the URL again.". The same page stays.
  2. If the endpoint resolves, then the monitor is added. There are no changes here.
@gorkem-bwl gorkem-bwl added the good first issue Good for newcomers label Jul 31, 2024
@lakshmi0605
Copy link

Hi, I want to work on this issue. Can I?

@ajhollid
Copy link
Contributor

ajhollid commented Sep 29, 2024

Hi, I want to work on this issue. Can I?

Hi @lakshmi0605, most certainly! This is an open source project so please feel free to contribute!

@om-3004 om-3004 linked a pull request Oct 12, 2024 that will close this issue
@om-3004
Copy link
Contributor

om-3004 commented Oct 12, 2024

Hello @gorkem-bwl @ajhollid, please review my PR and let me know if there are any issues

@gorkem-bwl
Copy link
Contributor Author

@om-3004 can you please make a video for this and upload here so I can check the behaviour?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants