Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DX9 and DX11 Cursor/Upscaling hooking code consistent #158

Open
Nintynuts opened this issue May 18, 2022 · 1 comment
Open

Make DX9 and DX11 Cursor/Upscaling hooking code consistent #158

Nintynuts opened this issue May 18, 2022 · 1 comment

Comments

@Nintynuts
Copy link
Collaborator

Nintynuts commented May 18, 2022 •
edited
Loading

Originally posted by @davegl1234 in #156 (comment)

Regarding the gedosato code, the functionality that was actually needed for DX9 I've since reimplemented, but functionally different (so no concerns there). E.g Rather than hooking GetMessage, PeakMessage, and the SetWindowLong wndproc stuff, I am replacing the wndproc of the window and forwarding (manipulated) messages to the real wndproc. So I can probably replace the gedosato stuff with this, to avoid the licensing issues.

I guess we should have DX9/DX11 using the same cursor/upscaling hooking code anyway, right?
@Nintynuts Nintynuts mentioned this issue May 18, 2022
Draft
@Nintynuts Nintynuts changed the title Make DX9 and DX11 Winproc hooking code consistent Make DX9 and DX11 Cursor/Upscaling hooking code consistent May 18, 2022
@Nintynuts Nintynuts mentioned this issue May 18, 2022
Open
@DarkStarSword
Copy link
Collaborator

@davegl1234 Sounds good. Please go ahead and do this, then once the GeDoSaTo code is removed I'll be able to reinstate the MIT license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DarkStarSword @Nintynuts